Skip to content

GO-6240 ownership transfer#185

Merged
cheggaaa merged 15 commits intomainfrom
GO-6240-ownership-transfer
Jan 13, 2026
Merged

GO-6240 ownership transfer#185
cheggaaa merged 15 commits intomainfrom
GO-6240-ownership-transfer

Conversation

@cheggaaa
Copy link
Copy Markdown
Member

@cheggaaa cheggaaa commented Nov 10, 2025

  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 10, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedgithub.com/​anyproto/​any-sync@​v0.11.4 ⏵ v0.11.774 +110010010070
Updatedgoogle.golang.org/​protobuf@​v1.36.10 ⏵ v1.36.1175 +1100100100100
Updatedgolang.org/​x/​sync@​v0.18.0 ⏵ v0.19.099100100100100

View full report

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 10, 2025 •
edited
Loading

New Coverage 61.9% of statements
Patch Coverage 72.7% of changed statements (189/260)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@cheggaaa cheggaaa marked this pull request as draft November 13, 2025 16:28
@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 12, 2026 •
edited
Loading

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: golang github.com/libp2p/go-libp2p is 98.0% likely obfuscated

Confidence: 0.98

Location: Package overview

From: ? → golang/github.com/anyproto/any-sync@v0.11.7 → golang/github.com/ipfs/go-block-format@v0.2.3 → golang/github.com/libp2p/go-libp2p@v0.46.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore golang/github.com/libp2p/go-libp2p@v0.46.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@cheggaaa cheggaaa marked this pull request as ready for review January 12, 2026 14:45
deff7
deff7 reviewed Jan 13, 2026
View reviewed changes
Comment thread index/move.go Outdated
"github.com/anyproto/any-sync-filenode/index/indexproto"
)

func (ri *redisIndex) CheckOwnership(ctx context.Context, key Key, oldIdentity string, aclRecordIndex int) (err error) {
Copy link
Copy Markdown
Member

@deff7 deff7 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CheckOwnership not only checks, but also moves ownership, maybe name it something like CheckAndMoveOwnership?

Copy link
Copy Markdown
Member Author

@cheggaaa cheggaaa Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cheggaaa cheggaaa merged commit 89ce034 into main Jan 13, 2026
6 checks passed
@cheggaaa cheggaaa deleted the GO-6240-ownership-transfer branch January 13, 2026 11:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deff7 deff7 deff7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cheggaaa @deff7